PLT-7614: Fixed Testing History Table

EehMauro commented 1 year ago

Summary by CodeRabbit

New Feature:

Added a loading spinner to the Table component. This provides visual feedback to users when data is being fetched, improving user experience by clearly indicating that the process is ongoing.

Refactor:

Updated the Table component to conditionally render all rows based on the showAllRows prop. This enhances table flexibility and usability.
Removed specific CSS classes from the FailedTaskDetails component in fullReportTable.helper.tsx. The impact of this change will depend on the overall styling context.

Chore:

Introduced a new state variable loading in testingHistory/index.tsx to manage the loading status of the data. This improves code readability and maintainability.

coderabbitai[bot] commented 1 year ago

Rate Limit Exceeded

You have exceeded the limit for the number of files or commits that can be reviewed per hour. Please wait 7 minutes and 11 seconds before requesting another review.

To re-trigger a review, convert this PR to a draft and then mark it as ready for review again. Alternatively, you can push a new commit to this PR.

coderabbitai[bot] commented 1 year ago

Walkthrough

This update introduces a loading state to the application, enhancing user experience by providing visual feedback during data fetching. The changes span across the Table component and pages that utilize it, ensuring consistent behavior throughout the application.

Changes

File	Summary
`src/components/Table/Table.tsx`	Introduced a `loading` prop to conditionally render a loading spinner. Updated table's initial state and pagination based on `showAllRows`. Added handling for empty data.
`src/pages/.../index.tsx`	Added a `loading` state variable to track data fetching status. This state is passed to the `Table` component.
`src/pages/certification/.../fullReportTable.helper.tsx`	Removed CSS classes defining background and border colors from `FailedTaskDetails` component.

🐇💻

In the land of code, where the brackets lie, A spinner spins, while the data we pry. No more blank stares, at an empty screen, For now we signal, when the data's unseen! 🔄🎉

Tips

### Chat with CodeRabbit Bot (`@coderabbitai`) - Mention `@coderabbitai` in any *review comment* for bot assistance. - Note: Review comments are made on code diffs or files, not on the PR overview. ### Pause Incremental Reviews - Insert `@coderabbitai: ignore` in the PR description to halt the bot's ongoing reviews. Remove the line to resume. - Additionally, enter `@coderabbitai pause` to halt the bot's ongoing reviews as any issue or review comment. To resume reviews, enter `@coderabbitai resume` as any issue or review comment.

amnambiar commented 1 year ago

Added two fixes -

For missing pagination and row-count in Testing History
For multiple nested vertical scrollbars in failed task details in Full Report View

input-output-hk / dapps-certification-web