search

input-output-hk / hackage-overlay-ghcjs

0 stars 1 forks source link

Patch Contents Causing Duplicate Function Definitions #3

Open Crypto2099 opened 1 month ago

Crypto2099 commented 1 month ago

The included "temporary fixes" here are causing duplicated function definitions when this patch is used during the JS build for cardano-addresses as referenced here: https://github.com/IntersectMBO/cardano-addresses/issues/264 and here: https://github.com/IntersectMBO/cardano-addresses/pull/267.

It is unclear where else in GHCJS these functions, specifically: geteuid(), sysconf(), getpwuid_r(), and foundation_sysrandom_linux() are being included from.

https://github.com/input-output-hk/hackage-overlay-ghcjs/blob/6281362356b382faf648e5161d3a58f7b0437d0f/patches/cryptonite-0.30.patch#L494-L528

Crypto2099 commented 1 month ago

The first three functions: geteuid(), sysconf(), and getpwuid_r() are already covered via the unix shim in ghcjs core: https://github.com/ghcjs/ghcjs/blob/b7711fbca7c3f43a61f1dba526e6f2a2656ef44c/lib/boot/shims/pkg/unix.js.pp#L14-L34

luite commented 1 month ago

We don't use the shims anymore in the JS backend. The unix package contains its own jsbits now.

Do you still run into this? Perhaps there's another place that needs a fix.