input-output-hk / haskell.nix

Alternative Haskell Infrastructure for Nixpkgs
https://input-output-hk.github.io/haskell.nix
Apache License 2.0
557 stars 239 forks source link

package..ghcOptions should be sent to the haddock command #2129

Open pranaysashank opened 10 months ago

pranaysashank commented 10 months ago

Describe the bug

package..ghcOptions are not sent to haddock

Steps To Reproduce

1) Add -XDuplicateRecordFields to a package that requires it in ghcOptions 2) Build the haddock derivation (via nix-shell), haddock build fails because it doesn't have the DuplicateRecordFields extension enabled.

Expected behavior

ghcOptions gets passed to haddock via --optghc

Additional context

I faced this issue when upgrading to 9.8.1, a few packages that were building fine before now require DuplicateRecordFields behaviour with a warning that the behaviour will be deprecated in the future. As a temporary fix, I passed the ghcOptions in the module settings for the package (amazonka). This builds fine, but haddock building fails. I set doHaddock = false for the package as part of the temporary fix

stale[bot] commented 6 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.