ShardedStore rollback is not propagated to shards

input-output-hk / iodb

Multiversioned key-value database, especially useful for blockchain

Creative Commons Zero v1.0 Universal

95 stars 13 forks source link

ShardedStore rollback is not propagated to shards #27

Closed jankotek closed 6 years ago

jankotek commented 6 years ago

If ShardedStore#rollback() is called, journal is rolled back and the shard pointers are updated. However the internal state (data) remains unchanged. So on next taskDistribute the rolled back data in shard are restored.

We need to:

taskDistribute() must attach versionID from journal to shards
on ShardedStore#rollback find versionID of last distribution and rollback all shards to this versionId

jankotek commented 6 years ago

This is now fixed, shards are rolled back with correct offset.