search

input-output-hk / iohk-nix

nix scripts shared across projects
62 stars 28 forks source link

move haskell-nix stuff out of crypto overlay #543

Closed jbgi closed 1 year ago

jbgi commented 1 year ago

so that crypto can be imported before haskell.nix overlay (though not currently necessary, but could be if we modify nixpkgs in there in the future), and the new haskell-nix-crypto overlay being imported after.

angerman commented 1 year ago

@jbgi thanks for this!

jbgi commented 1 year ago

I think we want one crypto overlay and one haskell.nix overlay.

I kind-of wanted to do that too (using the existing haskell-nix-extra overlay for the haskell-nix stuff), but then it would have induced a new dependency on the crypto overlay being loaded.

So probably a new crypto-haskell-nix (or haskell-nix-crypto?) would be the way to go.

angerman commented 1 year ago

@jbgi i think I prefer haskell-nix-crypto?

angerman commented 1 year ago

@jbgi how much code can we save if we just blatantly override the nix supplied secp256k1 instead of having to deal with our own libsecp256k1? Yes it's a bit ugly from the naming scheme with the other libraries, but are the hoops we jump through here to deal with secp256k1 vs libsecp256k1 worth it?

angerman commented 1 year ago

After our discussion yesterday, I think we should make an exception here for secp256k1, and just follow the upstream nix naming. This will make things much easier on us. We should do the same for libsodium, and eventually libblst (however that ends up in nixpkgs).

angerman commented 1 year ago

@jbgi let me know what you think. If you agree, this is good to merge I think.

jbgi commented 1 year ago

bors r+