search

input-output-hk / jormungandr

privacy voting blockchain node
https://input-output-hk.github.io/jormungandr/
Apache License 2.0
364 stars 132 forks source link

feat: Update the node's prometheus metrics #4142

Open saibatizoku opened 12 months ago

saibatizoku commented 12 months ago

Updates jormungandr node to initialize mempool and peer gauges to 0.

Closes https://github.com/input-output-hk/catalyst-core/issues/600

cong-or commented 12 months ago

golden commit: 47e874c5792bccd2eb073ef65ea89ac5d0525c04

we should make a branch off this and put all changes in here for A/B testing.

kukkok3 commented 12 months ago

Would not be better to wait until we have a stable jor node version and merge this change into that?

cong-or commented 12 months ago

Would not be better to wait until we have a stable jor node version and merge this change into that?

yea but we want to compare the "new" nodes performance vs the old node.

[Old:](golden commit: https://github.com/input-output-hk/jormungandr/commit/47e874c5792bccd2eb073ef65ea89ac5d0525c04)

New: Branch from gold. Silver?

saibatizoku commented 12 months ago

Would not be better to wait until we have a stable jor node version and merge this change into that?

yea but we want to compare the "new" nodes performance vs the old node.

[Old:](golden commit: 47e874c)

New: Branch from gold. Silver?

I think that we can rename to whichever name is better suited to do A/B testing (e.g. branch-A, branch-B), and create a tag when we have reached a conclusion.