input-output-hk / lace

The Lace Wallet.
https://lace.io
Apache License 2.0
16 stars 5 forks source link

fix(extension): send balance UI no longer glitches when input field loses focus #1535

Closed AngelCastilloB closed 3 days ago

AngelCastilloB commented 5 days ago

Checklist


Proposed solution

Currently in Lace when the input field loses focus (blur) the UI re-renders with the review-transaction greyed disabled for a split second, If the user changes focus by clicking the button, it needs to click twice. This is caused by a specific flag that checks whether the max ADA available was already computed to be used in a specific button of the UI. I removed this check, now the UI re-renders with the button enabled. Removing this check doesn't seems to have any negative effect in the MAX ADA functionality.

The interface now doesn't require a double click on the review button

Testing

Describe here, how the new implementation can be tested. Provide link or briefly describe User Acceptance Criteria/Tests that need to be met

Screenshots

Attach screenshots here if implementation involves some UI changes

sonarcloud[bot] commented 5 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

pczeglik-iohk commented 5 days ago

Allure Report

allure-report-publisher generated test report!

processReports: ✅ test report for bd80413c passed failed skipped flaky total result
Total 32 0 4 0 36