search

input-output-hk / marlowe-playground

Apache License 2.0
6 stars 7 forks source link

PLT-5930: Add dependencies needed for e2e tests. #37

Open shlevy opened 1 year ago

shlevy commented 1 year ago

Note that tests now fail with:

Error: ENOENT: no such file or directory, scandir '/home/shlevy/src/iog/marlowe-playground/e2e/config/mappings/fixtures/'

and later

/home/shlevy/src/iog/marlowe-playground/e2e/node_modules/cucumber-html-reporter/lib/hierarchyReporter.js:20 suite.features.forEach(function (feature) { ^ TypeError: suite.features.forEach is not a function

ladamesny commented 1 year ago

hey @shlevy thanks for working on this. I just rebased your branch with the tests I'm working on. I tried running the tests with firefox and webkit and I got the following message:

   browserType.launch: Executable doesn't exist at /nix/store/vqz7samp6r3c532cnxjhqwwl96n7w1px-playwright-browsers/webkit-1837/pw_run.sh

   ║ Looks like Playwright Test or Playwright was just installed or updated. ║
   ║ Please run the following command to download new browsers:              ║
   ║                                                                         ║
   ║     npx playwright install                                              ║
   ║                                                                         ║
   ║ <3 Playwright Team

I then ran "npx playwright install" and it was just hanging.

To set the browser, change the UI_AUTOMATION_BROWSER env variable in e2e/env/common.env to 'firefox' or 'webkit' and then run . ./run_tests.sh wip from the e2e folder.

Chromium still works for me locally.

shlevy commented 1 year ago

@ladamesny I'm unable to test any further due to the errors shared above (which are still there after rebase)

ladamesny commented 1 year ago

Hi @shlevy I just removed references to fixtures from the code. That first error indicates that it can't find the folder '/home/shlevy/src/iog/marlowe-playground/e2e/config/mappings/fixtures/', which is weird because the folder was checked in.

The second error message usually means that it can't find the **.features files, which is also checked in and should be under '/home/shlevy/src/iog/marlowe-playground/e2e/src/features/*'.

Do you want to look at it together on Monday? Feels like this should be easy to resolve together. Thanks!

shlevy commented 1 year ago

I'm not available to meet today or tomorrow, I might have time Wednesday and I'll definitely have time Thursday.