input-output-hk / marlowe-playground

Apache License 2.0
6 stars 7 forks source link

PLT-3985 - Show initial time for counterexamples in a human readable way #57

Closed palas closed 1 year ago

palas commented 1 year ago

This PR fixes a legacy vestige that caused the initial time of a counter example produced by the static analysis to be shown as a slot, even though it was an amount of milliseconds. So this PR changes the type names that referred to slots and displays the value as a date and a time.

It also updates the README.md that had one of the commands spelled wrong, and adds the scriv command to the nix development shell.

Pre-submit checklist:

palas commented 1 year ago

The code looks good, but I got this error while trying the static analysis... Not sure if related

Screenshot 2023-11-17 at 17 10 48

...Failure: An error occurred while decoding a JSON value: Under 'Response': At object key 'result': Under 'Result': Under 'CounterExample': No value was found.

I cannot reproduce it. Have you run generate-purescript and the other commands in the README.md?