input-output-hk / mithril

Stake-based threshold multi-signatures protocol
https://mithril.network
Apache License 2.0
116 stars 36 forks source link

Sign `Cardano Transactions` with `Block Range Merkle Roots` #1660

Closed jpraynaud closed 2 months ago

jpraynaud commented 2 months ago

Content

This PR includes the computation of the Cardano Transactions signature with the pre-computed Block Range Merkle Roots retrieved from the store:

Pre-submit checklist

Issue(s)

Closes #1634

github-actions[bot] commented 2 months ago

Test Results

    3 files  ±0     43 suites  ±0   8m 27s :stopwatch: -1s   974 tests  - 2    974 :white_check_mark:  - 2  0 :zzz: ±0  0 :x: ±0  1 068 runs   - 2  1 068 :white_check_mark:  - 2  0 :zzz: ±0  0 :x: ±0 

Results for commit 7094e3ac. ± Comparison against base commit 512fe8d0.

This pull request removes 3 and adds 1 tests. Note that renamed tests count towards both. ``` mithril-common ‑ signable_builder::cardano_transactions::tests::test_compute_merkle_root_in_same_block_range mithril-common ‑ signable_builder::cardano_transactions::tests::test_compute_merkle_root_order_of_block_range_does_not_matter mithril-common ‑ signable_builder::cardano_transactions::tests::test_compute_signable_with_no_transaction_return_error ``` ``` mithril-common ‑ signable_builder::cardano_transactions::tests::test_compute_signable_with_no_block_range_root_return_error ```

:recycle: This comment has been updated with latest results.