input-output-hk / mithril

Stake-based threshold multi-signatures protocol
https://mithril.network
Apache License 2.0
115 stars 36 forks source link

feat(tls): Allow the underlying TLS implementation to be selected by feature flags. #1738

Closed stevenj closed 3 weeks ago

stevenj commented 4 weeks ago

Content

The mithril-client library uses the reqwest crate. By default, reqwest uses OpenSSL for TLS support in HTTPS requests. This causes any consumer of the library to have a dynamic dependency on a system OpenSSL library.

reqwest has a number of options for fulfilling tls functionality. This patch just exposes that, using the same feature flags that reqwest uses.

Pre-submit checklist

Comments

This PR came about because our project requires static linking of dependent libraries, and this was not possible when using the mithril-client crate.

Issue(s)

Closes #1737

jpraynaud commented 3 weeks ago

@stevenj could you bump the patch version of the mithril-client crate before we can merge the PR?