input-output-hk / mithril

Stake-based threshold multi-signatures protocol
https://mithril.network
Apache License 2.0
115 stars 36 forks source link

Fix #1762: CardanoTransactionSnapshot block number is not certified #1779

Closed Alenar closed 1 week ago

Alenar commented 1 week ago

Content

This PR fixes #1762:

It was due to the request to retrieve the pre-computed block range roots in database using a exclusive bound comparison instead of an inclusive, leading to the exclusion of the last block range root from the retrieved data.

This means that not only the prover was impacted but the protocol message generation for the single & multi signatures too.

Pre-submit checklist

Comments

Even if mithril-signer and mithril-aggregator are not modified by this PR, their behavior is impacted so their version number should be upgraded.

Issue(s)

Closes #1762

github-actions[bot] commented 1 week ago

Test Results

    4 files  ±0     51 suites  ±0   8m 49s :stopwatch: ±0s 1 090 tests ±0  1 090 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 238 runs  ±0  1 238 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 985c63d6. ± Comparison against base commit 0ebb9a51.

:recycle: This comment has been updated with latest results.