input-output-hk / mithril

Stake-based threshold multi-signatures protocol
https://mithril.network
Apache License 2.0
115 stars 36 forks source link

Conditional embedding cardano cli in docker image #1789

Closed sfauvel closed 4 days ago

sfauvel commented 1 week ago

Content

By default, build docker images (aggregator and signer) without Cardano CLI which is useless when using Pallas.

We can embed it setting to 1 the build arg EMBED-CARDANO-CLI.

Example: docker build -t mithril/mithril-aggregator --build-arg EMBED-CARDANO-CLI=1 -f mithril-aggregator/Dockerfile .

Pre-submit checklist

Issue(s)

Closes 1725

github-actions[bot] commented 1 week ago

Test Results

    4 files  ±0     51 suites  ±0   8m 54s :stopwatch: +6s 1 101 tests ±0  1 101 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 249 runs  ±0  1 249 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 4e6e69f0. ± Comparison against base commit ed03ede1.

:recycle: This comment has been updated with latest results.