Bugfix: Can't generate proof for transactions on the last signed block number

[Alenar]

Content

This PR includes a fix for #1785, there was several problems:

• The computed block number to be signed was not taking in account the fact that block range ends is exclusive, meaning that it overflowed over the next block range, a block range which end after the block number that we want to sign. To solve this we simply subtract one to the computation.
• The request that retrieved block range when computing merkle roots excluded the last block range.

Not directly related to the bug:

• The prover would add leaf to it's merkle tree in some condition, corrupting it as this changed its merkle root so it no longer matcher the one in the certificate. This was worrisome since this corrupted merkle tree is returned to a resource pool after use, meaning that a subsequent requests would also yield invalid proofs.

Pre-submit checklist

• Branch
  • [x] Tests are provided (if possible)
  • [x] Crates versions are updated (if relevant)
  • [x] Commit sequence broadly makes sense
  • [x] Key commits have useful messages
• PR
  • [x] No clippy warnings in the CI
  • [x] Self-reviewed the diff
  • [x] Useful pull request description
  • [x] Reviewer requested

Comments

I'm unsure this totally fix the problem as when investing the logs I could see that, in the transaction importer, they were a gap of minus one between the block number of the transaction we asked it to import and the really imported transactions. We should oversee the testing preview network after merge to ensure that its fixed or if there's still more work needed.

Issue(s)

Relates to #1785

[github-actions[bot]]

Test Results

    4 files  ±0     52 suites  +1   8m 45s :stopwatch: +5s 1 123 tests +9  1 123 :white_check_mark: +9  0 :zzz: ±0  0 :x: ±0  1 271 runs  +9  1 271 :white_check_mark: +9  0 :zzz: ±0  0 :x: ±0 

Results for commit 10e2a20d. ± Comparison against base commit f10e4eb0.

:recycle: This comment has been updated with latest results.