input-output-hk / mithril

Stake-based threshold multi-signatures protocol
https://mithril.network
Apache License 2.0
130 stars 41 forks source link

Remove beacon from certificate #2055

Closed Alenar closed 3 weeks ago

Alenar commented 3 weeks ago

Content

This PR remove the beacon field from the CertificateMessage and CertificateListMessage as this field was supersede by the signed_entity_type field, field that is mandatory since distribution 2418.1.

This allow to remove the immutable_file_number plus the conversion to cardano db beacon on the CertificateMetadata entity and the CertificateRecord, those only existed to recover the beacon when building a message.

[!WARNING]

Nodes from distribution below 2430 are not compatible with this change.

Pre-submit checklist

Comments

This changes should not induce a recompute of the certificates hashes as the immutable file number was not used in the certificate hash computation (the epoch and the network are still used).

Issue(s)

Closes #1958

github-actions[bot] commented 3 weeks ago

Test Results

    4 files  ±0     51 suites  ±0   10m 41s ⏱️ +15s 1 398 tests  - 2  1 398 ✅  - 2  0 💤 ±0  0 ❌ ±0  1 609 runs   - 2  1 609 ✅  - 2  0 💤 ±0  0 ❌ ±0 

Results for commit 22dc14fd. ± Comparison against base commit 650e77d0.

This pull request removes 4 and adds 2 tests. Note that renamed tests count towards both. ``` mithril-common ‑ messages::certificate::tests::test_actual_json_deserialized_into_previous_message mithril-common ‑ messages::certificate::tests::test_json_next_version_deserialized_into_actual_message mithril-common ‑ messages::certificate_list::tests::test_actual_json_deserialized_into_previous_message mithril-common ‑ messages::certificate_list::tests::test_json_next_version_deserialized_into_actual_message ``` ``` mithril-common ‑ messages::certificate::tests::test_actual_json_deserialized_into_message_supported_until_open_api_0_1_32 mithril-common ‑ messages::certificate_list::tests::test_actual_json_deserialized_into_message_supported_until_open_api_0_1_32 ```

:recycle: This comment has been updated with latest results.