input-output-hk / mithril

Stake-based threshold multi-signatures protocol
https://mithril.network
Apache License 2.0
130 stars 41 forks source link

Prepare network removal from `CardanoDbBeacon` #2097

Closed Alenar closed 2 weeks ago

Alenar commented 2 weeks ago

Content

This PR ensure that the upcoming removal of the network field from the CardanoDbBeacon won't cause incompatibility in the network even with yet to update node.

Entites Adaptation

Messages Adaptation

[!WARNING] The new network field is mandatory in SnapshotMessage, SnapshotListMessage, or SnapshotDownloadMessage. This mean that a upgraded client is not compatible with not upgraded aggregators.

Services Adaptation

Other

Pre-submit checklist

Issue(s)

Relates to #1957

github-actions[bot] commented 2 weeks ago

Test Results

    4 files  ±0     51 suites  ±0   10m 30s ⏱️ +3s 1 425 tests +8  1 425 ✅ +8  0 💤 ±0  0 ❌ ±0  1 636 runs  +8  1 636 ✅ +8  0 💤 ±0  0 ❌ ±0 

Results for commit e0f14899. ± Comparison against base commit 8db29414.

This pull request removes 8 and adds 16 tests. Note that renamed tests count towards both. ``` mithril-common ‑ messages::certificate_pending::tests::test_actual_json_deserialized_into_previous_message mithril-common ‑ messages::register_signature::tests::test_actual_json_deserialized_into_previous_message mithril-common ‑ messages::snapshot::tests::test_v1 mithril-common ‑ messages::snapshot::tests::test_v2 mithril-common ‑ messages::snapshot_download::tests::test_v1 mithril-common ‑ messages::snapshot_list::tests::test_v1 mithril-common ‑ messages::snapshot_list::tests::test_v2 mithril-common ‑ messages::snapshot_list::tests::test_v3 ``` ``` mithril-common ‑ digesters::cardano_immutable_digester::tests::test_compute_beacon_hash mithril-common ‑ entities::cardano_network::tests::network_to_string mithril-common ‑ messages::certificate_pending::tests::test_actual_json_deserialized_into_message_supported_until_open_api_0_1_25 mithril-common ‑ messages::message_parts::signed_entity_type_message::tests::comparing_message_to_cardano_db_beacon_entity mithril-common ‑ messages::message_parts::signed_entity_type_message::tests::comparing_message_to_signed_entity_type_entity mithril-common ‑ messages::message_parts::signed_entity_type_message::tests::convert_cardano_db_beacon_entity_to_message mithril-common ‑ messages::message_parts::signed_entity_type_message::tests::convert_message_to_cardano_db_beacon_entity mithril-common ‑ messages::message_parts::signed_entity_type_message::tests::convert_message_to_signed_entity_type_entity mithril-common ‑ messages::message_parts::signed_entity_type_message::tests::convert_signed_entity_type_entity_to_message mithril-common ‑ messages::register_signature::tests::test_actual_json_deserialized_into_message_supported_until_open_api_0_1_28 … ```

:recycle: This comment has been updated with latest results.