Closed Alenar closed 2 weeks ago
4 files ±0 51 suites ±0 10m 30s ⏱️ +3s 1 425 tests +8 1 425 ✅ +8 0 💤 ±0 0 ❌ ±0 1 636 runs +8 1 636 ✅ +8 0 💤 ±0 0 ❌ ±0
Results for commit e0f14899. ± Comparison against base commit 8db29414.
:recycle: This comment has been updated with latest results.
Content
This PR ensure that the upcoming removal of the network field from the
CardanoDbBeacon
won't cause incompatibility in the network even with yet to update node.Entites Adaptation
network
field toSnapshot
entity: since the snapshot is very strongly tied to the network it's based on, this ensure that this metadata remain easily available.CardanoImmutableFilesFullArtifactBuilder
when a snapshot is build using the network from the configurationSnapshot
artifact in the aggregator databasesigned_entity
tableMessages Adaptation
network
field toSnapshotMessage
,SnapshotListMessage
, andSnapshotDownloadMessage
CardanoDbBeaconMessagePart
: a duplicate of the actualCardanoDbBeacon
but with a optional network.CertificatePendingMessage
,SnapshotMessage
,SnapshotListMessage
, andSnapshotDownloadMessage
SignedEntityTypeMessagePart
: a duplicate of the actualSignedEntityType
, needed because half of the usages of theCardanoDbBeacon
are through theSignedEntityType
CertificateMessage
,CertificateListMessage
,CertificatePendingMessage
, andRegisterSignatureMessage
CardanoDbBeacon
to ensure that its removal won't impact the messages:network
for:CertificateMessage
,CertificateListMessage
CertificatePendingMessage
,RegisterSignatureMessage
network
field when converting snapshot entities toSnapshotMessage
,SnapshotListMessage
, orSnapshotDownloadMessage
Services Adaptation
CardanoImmutableDigester
compute the beacon hash that's added its result by itself instead of relying on theCardanoDbBeacon
codeCardanoDbBeacon::compute_hash
and adapted to take a parametrized network so it don't rely on the soon removedCardanoDbBeacon::network
CardanoImmutableDigester
won't change after removing the network from theCardanoDbBeacon
Other
compression_algorithm
andcardano_node_version
mandatory in theSnapshotMessage
andSnapshotListMessage
. They were added as optional in order to avoid breaking changes with yet to upgrade nodes, since it was back in distribution2337
enough time as passed to ensure that all nodes are upgraded and won't break with those fields marked as mandatory.Pre-submit checklist
Issue(s)
Relates to #1957