input-output-hk / nami

Nami Wallet is a browser based wallet extension to interact with the Cardano blockchain. Support requests: https://iohk.zendesk.com/hc/en-us/requests/new
https://namiwallet.io
Apache License 2.0
373 stars 167 forks source link

Compatibility with Vasil hardfork features #576

Open ngua opened 2 years ago

ngua commented 2 years ago

Hello! I'd like to ask about compatibility with features introduced in the upcoming Vasil hardfork. First, a bit of context: I'm one of the implementers/maintainers of cardano-transaction-lib, which is an attempt at creating a browser-based environment for building smart contract transactions (its public API is directly inspired by PAB). Nami is the first wallet we added support for and continues to be the primary wallet we support and develop against

We're going to start adding support for features introduced in the hardfork soon. To do so, we will probably need to work on cardano-serialization-lib directly as it is also our direct dependency. We're concerned that the serialized values produced by our fork of CSL after implementing the new features will be incompatible with the version used by Nami. We were wondering if it might be possible to collaborate on an experimental version of Nami that works with our hardfork-compatible fork of CSL

Thanks for creating Nami!

alessandrokonrad commented 2 years ago

Hey sorry for the late reply. Yes I'm going to make Nami Vasil compatible. As long as the serialized version of the tx conforms to the babbage CDDL it shouldn't be any problem for nami parsing and signing your transactions.

ngua commented 2 years ago

Thank you @alessandrokonrad!