input-output-hk / offchain-metadata-tools

Tools for creating, submitting, and managing off-chain metadata such as multi-asset token metadata
Apache License 2.0
46 stars 33 forks source link

Attestation (-a) can result in duplicate signatures #15

Open catch-21 opened 3 years ago

catch-21 commented 3 years ago

When signing all metadata for a second time then duplicate keys are included in metadata json. It would be more user friendly if it overwrote existing signatures.

For example

Actual Result

Metadata json has duplicate signatures for description.

Expected Result

No duplicates, only one signature entry per pubkey.

Notes

It is possible to specify --attest-name to prevent the duplication of description signatures in the above scenario, but it would still be good to validate and prevent duplicates from being possible.

catch-21 commented 3 years ago

https://github.com/cardano-foundation/cardano-token-registry/wiki/How-do-I-update-my-entry-in-the-registry%3F This page in the token registry wiki actually says "Produce new signatures using cardano-metadata-submitter that will replace the existing ones", just incase this bumped priority here.