search

input-output-hk / quickcheck-contractmodel

Adversary testing of your plutus contract
Apache License 2.0
7 stars 9 forks source link

Bump qc-d dependency #20

Closed MaximilianAlgehed closed 1 year ago

MaximilianAlgehed commented 1 year ago

Update the dependency on quickcheck-dynamic to point to the latest version.

MaximilianAlgehed commented 1 year ago

@berewt any clue what's up with ci here?

sjoerdvisscher commented 1 year ago

Sorry, ignore that :)

MaximilianAlgehed commented 1 year ago

@sjoerdvisscher this is ready for review, by the way. There isn't really much here right now. Quickcheck-dynamic 3.2.0 introduces primitives for negative testing that we could use in quickcheck-contractmodel but I haven't gotten around to it yet.

berewt commented 1 year ago

@berewt any clue what's up with ci here?

I guess it has to do with "Yet another CI change" (and either not enough nix outputs or not with a standardised name). I saw that there's an ongoing IOGx PR. It may improve things once we merge it. Otherwise, maybe @zeme-wana could have a look.

zeme-wana commented 1 year ago

This PR is failing because there are no hydraJobs outputs in the flake. This is expected: we've added this repo to CI but not updated the flake yet. I suggest we merge this PR first (https://github.com/input-output-hk/quickcheck-contractmodel/pull/21) And the we can deal with this one

MaximilianAlgehed commented 1 year ago

@zeme-wana that sounds good. Just let me know when the other PR is ready and I expect we can merge it right away.

zeme-wana commented 1 year ago

https://github.com/input-output-hk/quickcheck-contractmodel/pull/22 has been merged. We can now merge this.

Remember that the formatters are not enabled yet. You will want to open a new PR, set cabal-fmt.enable = true; fourmolu.enable = true; in ./nix/formatters.nix then run pre-commit run --all-files @MaximilianAlgehed

MaximilianAlgehed commented 1 year ago

@zeme-wana this appears to be stuck on flaky CI.

zeme-wana commented 1 year ago

I restarted the false-negative build failures on Hydra and now it's all good.