search

input-output-hk / testnet-stake-pool-registry-validator

Testnet stake pool registry validator.
Apache License 2.0
3 stars 0 forks source link

Validation of homepage URI scheme #4

Closed rvl closed 4 years ago

rvl commented 4 years ago

When validating the homepage field, can we ensure that the URI scheme is either http or https?

Also there is a typo on the line with <?> AE.Key "homepate".

KtorZ commented 4 years ago

Damn. Good point about the typo, thanks @rvl For the URI, it already checks about https and rejects non-secure URLs:

https://github.com/input-output-hk/testnet-stake-pool-registry-validator/blob/master/app/registry.hs#L400-L410

deepfire commented 4 years ago

@rvl, I've added a test to elaborate the https schema enforcement: https://github.com/input-output-hk/testnet-stake-pool-registry/tree/31-non-https-homepage