search

input-output-hk / voting-tools

Apache License 2.0
17 stars 10 forks source link

Fix reward address #54

Closed kderme closed 1 year ago

kderme commented 1 year ago

CIp https://github.com/cardano-foundation/CIPs/tree/master/CIP-0036 Fund 10, replaced the reward stake address by a regular shelley address. This pr fixes the expected 61284 -> 3 value of registration metadata, while it still accepts the legacy stake reward address for backwards compatibility.

Additioanlly it adds more logs, like

[Info] Connecting to database at /var/run/postgresql
[Info] Found 976 votes
[Info] Managed to succesfully parse 927 votes
[Info] Found 216 distinct stake keys
[Info] Found 81 of them with valid Shelley address payment credentials, while 135 use legacy stake reward addresses

and also introduced the --verbose flag to voting-tools for additional logs.

New registrations also require a Shelley addres. The legacy stake reward address is no longer supported.

stevenj commented 1 year ago

Doesn't look like my approving review is enough. I have tested this and it works great. The extra output is a nice touch as well. Thankyou.

minikin commented 1 year ago

@sevanspowell @disassembler @manveru @piotr-iohk Can someone approve and merge this one, please?