search

inputlogic / pwa-starter

A starting point for Preact based PWAs (WIP)
MIT License
3 stars 0 forks source link

Rename apps with more specific meanings #69

Closed weslord closed 4 years ago

weslord commented 4 years ago

I found myself frequently getting confused, since 'dashboard' and 'main' were pretty broad terms, so I needed constant reminders that 'dashboard' was the user dashboard and 'main' was the elements gallery (especially now that the auth pages have been removed from 'main').

The apps (and header links) have been renamed and the gallery components have been de-nested one level.

I left a very simple and generic 'main' app that redirects to the elements gallery, since a generic entrypoint at the / route seems like something we'd want to keep (or at least start with) for pretty much all projects.

github-actions[bot] commented 4 years ago

Size Change: +167 B (0%)

Total Size: 68.2 kB

Filename Size Change
public/module/dashboard-89b60d5e.js 0 B -409 B (0%)
public/module/index-1bfa98e9.js 0 B -926 B (0%)
public/module/index-45df4d9e.js 0 B -1.97 kB (0%)
public/module/index-b69449f9.js 0 B -4.09 kB (0%)
public/module/index.js 10.6 kB +67 B (0%)
public/module/url-0f3d1b51.js 0 B -16.4 kB (0%)
public/nomodule/dashboard-0e979c3c.js 0 B -419 B (0%)
public/nomodule/index-0c5b978c.js 0 B -903 B (0%)
public/nomodule/index-43babdcc.js 0 B -3.91 kB (0%)
public/nomodule/index-ee580136.js 0 B -1.9 kB (0%)
public/nomodule/index.js 10.3 kB +57 B (0%)
public/nomodule/url-b501aeb5.js 0 B -16 kB (0%)
public/module/dashboard-fc12694a.js 411 B +411 B (100%) 🆘
public/module/index-0f7314de.js 927 B +927 B (100%) 🆘
public/module/index-a096ab09.js 1.97 kB +1.97 kB (100%) 🆘
public/module/index-b4ac2481.js 4.09 kB +4.09 kB (100%) 🆘
public/module/url-b290513a.js 16.4 kB +16.4 kB (100%) 🆘
public/nomodule/dashboard-62037980.js 423 B +423 B (100%) 🆘
public/nomodule/index-0980cbe0.js 1.9 kB +1.9 kB (100%) 🆘
public/nomodule/index-7538cbee.js 3.91 kB +3.91 kB (100%) 🆘
public/nomodule/index-d02ed5e3.js 904 B +904 B (100%) 🆘
public/nomodule/url-406f210d.js 16 kB +16 kB (100%) 🆘
ℹī¸ View Unchanged | Filename | Size | Change | | |:--- |:---:|:---:|:---:| | `public/workers/request.js` | 419 B | 0 B | |

compressed-size-action

staydecent commented 4 years ago

Hmm, I think this makes more work for a new app. The only reason dashboard and main were separated was to show how to enforce authentication for an app, and how to lazy load an app.

If anything, we should just combine the apps/routes that will not be used in an actual project into a single "starter" app that can just be deleted entirely.

Examples of how to lazy load and authenticate, could be added to the README, to reduce the amount of example code when starting a new project.

The users app was added to show how to request data, before we had any README's for elements. I think leaving the element usage to the elements docs and eventual documentation site can help us trim down pwa-starter.

weslord commented 4 years ago

I disagree that this creates more work on project startup (it's clear which two app directories are examples, so you delete them and trace the dead references back to index and routes), but I am a fan of the idea of having a single, easily deletable 'example' app.

Will attempt simplify further.