search

inputlogic / pwa-starter

A starting point for Preact based PWAs (WIP)
MIT License
3 stars 0 forks source link

.eslintrc.js needs a .eslintrceslintrc.js #74

Closed adriaanwm closed 4 years ago

adriaanwm commented 4 years ago

The .eslintrc.js file has inconsistent use of double and single quotes. One solution would be to add a eslinrc for the estlintrc... eslintrceslintrc.js

staydecent commented 4 years ago

Why does this matter? One of the new rules is to not care about single vs double quotes..

https://github.com/inputlogic/pwa-starter/blob/master/.eslintrc.js#L42

staydecent commented 4 years ago

Let me know if you want to discuss amending the quote rule. I figured it offers no real benefit, to enforce one over the other.

Sometimes it's nice to switch so you don't need to escape quotes:

alert('Say "Hello"')
alert("Say 'Hello'")
weslord commented 4 years ago

Personally I think we should enforce backticks (`) as the quote convention

adriaanwm commented 4 years ago

My left pinky doesn't have the endurance for that yet, can we have a few weeks of transition training first?