Allow object keys to be in quotes. Allow unused vars starting with `_`.

github-actions[bot] commented 4 years ago

Size Change: -6 B (0%)

Total Size: 46.9 kB

Filename	Size	Change
`public/module/1593457757365-index.js`	0 B	-20.6 kB (0%)
`public/module/index-75c4c098.js`	0 B	-574 B (0%)
`public/module/index-dd835880.js`	0 B	-321 B (0%)
`public/module/use-request.m-0e3213a8.js`	0 B	-1.44 kB (0%)
`public/nomodule/1593457757365-index.js`	0 B	-20.7 kB (0%)
`public/nomodule/index-6917c84d.js`	0 B	-621 B (0%)
`public/nomodule/index-bf15c6f7.js`	0 B	-374 B (0%)
`public/nomodule/use-request.m-2764f79e.js`	0 B	-1.51 kB (0%)
`public/module/1593457728805-index.js`	20.6 kB	+20.6 kB (100%)	🆘
`public/module/index-1192c1ff.js`	573 B	+573 B (100%)	🆘
`public/module/index-de4a0117.js`	320 B	+320 B (100%)	🆘
`public/module/use-request.m-0a0cd3d8.js`	1.44 kB	+1.44 kB (100%)	🆘
`public/nomodule/1593457728805-index.js`	20.7 kB	+20.7 kB (100%)	🆘
`public/nomodule/index-2dad8598.js`	621 B	+621 B (100%)	🆘
`public/nomodule/index-a5059731.js`	374 B	+374 B (100%)	🆘
`public/nomodule/use-request.m-83d1994c.js`	1.51 kB	+1.51 kB (100%)	🆘

ℹ️ View Unchanged

| Filename | Size | Change | | |:--- |:---:|:---:|:---:| | `public/workers/cache.js` | 320 B | 0 B | | | `public/workers/request.js` | 419 B | 0 B | |

_{compressed-size-action}

staydecent commented 4 years ago

@adriaanwm How do you feel about:

"no-unused-vars": ["error", { "vars": "local", "args": "none", 'argsIgnorePattern': '^_' }]

So if I do:

const amIUsed = 42

And never use it, it bugs out.

But it won't bug out on:

const [_, other] = useState()
//nor
function (ev) => console.log('clicked')

?

adriaanwm commented 4 years ago

@staydecent that sounds good!

inputlogic / pwa-starter

Allow object keys to be in quotes. Allow unused vars starting with `_`. #75