search

inpyjama / c-ninja-listings

Lower level assembly and C baremetal programming on RISC-V CPUs. Source code listings from the C-Ninja, in Pyjama! book.
https://inpyjama.com
96 stars 480 forks source link

Dcokerfile adduser command #30

Closed vibraniumSwaleh closed 6 months ago

vibraniumSwaleh commented 6 months ago

The adduser command in the Dockerfile fails on my Windows 11 system. I changed it to useradd and the installation was completed successfully.

image

streetdogg commented 6 months ago

@vibraniumSwaleh Looks like many files are modified as part of the PR. I suppose it may have to do with the File Permissions change (since you were on Windows). I added a fix as part of this commit - https://github.com/inpyjama/c-ninja-listings/commit/22e0dfa0d47741c3db35e82087d780dc8228dc79

Can you check if this resolves the issue? If not, can I request you to clean up the PR and resubmit?

vibraniumSwaleh commented 6 months ago

@streetdogg That fixed it. I installed it again with the changes you made, and it worked. Thanks for your attention to this.

vibraniumSwaleh commented 6 months ago

@streetdogg I'll close this then.

Thanks.

streetdogg commented 5 months ago

thanks for confirming, @vibraniumSwaleh! :)