search

inrupt / friend-requests-exploration

An exploration into how Solid users might send each other friend requests
MIT License
3 stars 2 forks source link

can't discover friends-group's inbox if you don't have access to the friends-group #72

Closed michielbdejong closed 4 years ago

michielbdejong commented 4 years ago

that's a bit of a chicken-and-egg problem. So maybe I should move that triple from the friends group to the profile! So here:

https://github.com/inrupt/friend-requests-exploration/blob/master/src/services/createFriendsList.ts#L89-L90

It's currently here: https://github.com/inrupt/friend-requests-exploration/blob/master/src/services/createFriendsList.ts#L116

michielbdejong commented 4 years ago

And then i should also read it from the inbox in https://github.com/inrupt/friend-requests-exploration/blob/master/src/services/sendActionNotification.ts#L22 (maybe add a second parameter to determineUriInbox in case the inbox should be discovered from a different doc than what the URI dereferences to.

CC @Vinnl what do you think?

michielbdejong commented 4 years ago

Implemented this in master, testing it now.

michielbdejong commented 4 years ago

Fixed, but see also #73