uncommented rdflib import line

inrupt / generator-solid-angular

Generator for Solid Angular applications

MIT License

31 stars 12 forks source link

uncommented rdflib import line #14

Closed tiagosomda closed 5 years ago

tiagosomda commented 5 years ago

This is with respect to : https://github.com/Inrupt-inc/generator-solid-angular/issues/13

The line was commented out on this change: https://github.com/Inrupt-inc/generator-solid-angular/commit/1c91ae705d3b37f6567d929273154583d7012e4a#diff-dca975bf5ad72321f0990d8416fddab0

Uncommenting it fixed the project for me - I don't have other systems (mac, linux) to test this on.

scenaristeur commented 5 years ago

got the same issue, uncomment resolve it, on windows too

james-martin-jd commented 5 years ago

I'm going to reject this PR for now. In my testing the import $rdf will compile, but fails actually using the library at runtime. Additional work is required in the rdflib.js library to import properly and an issue was opened for it.