search

inrupt / generator-solid-angular

Generator for Solid Angular applications
MIT License
31 stars 12 forks source link

Generated App has security bugs #2

Closed willemneal closed 5 years ago

willemneal commented 5 years ago

Here is a generated repo and github says this:

We found a potential security vulnerability in one of your dependencies. A dependency defined in package-lock.json has known security vulnerabilities and should be updated.

Only users who have been granted access to vulnerability alerts for this repository can see this message. Learn more about vulnerability alerts

screen shot 2018-09-30 at 1 50 30 pm

I'm updating now the generated code, but I thought I'd pass it along upstream now.

james-martin-jd commented 5 years ago

Thanks Willem, taking a look at this soon

james-martin-jd commented 5 years ago

Looks like this was an issue with an old version of karma. Our tests aren't written yet anyway, so I upgraded to 3.0 and that removed the offending package dependency.

Fixed in 0.1.3