search

inrupt / pod-server

Solid server package that bind together solid-idp, wac-ldp, and websockets-pubsub.
MIT License
40 stars 12 forks source link

source files built into wrong folder #46

Open michielbdejong opened 5 years ago

michielbdejong commented 5 years ago

It's putting files in dist/src/ instead of directly in dist/.

steps to reproduce

in the master branch:

rm -r dist/
npm install
npm run build

expected

~/gh/inrupt/pod-server $ ls dist/
__mocks__        provision.js        rootRender.js        server.js        standalone.d.ts        streams.d.ts        views
koa-views        provision.js.map    rootRender.js.map    server.js.map        standalone.js        streams.js
provision.d.ts        rootRender.d.ts        server.d.ts        solid-idp        standalone.js.map    streams.js.map

actual

~/gh/inrupt/pod-server $ ls dist/
koa-views    package.json    solid-idp    src        views

workaround

run mv dist/src/* dist/ each time after npm run build.

jaxoncreed commented 5 years ago

The reason for this was importing package.json. This has been fixed in the lerna branch (https://github.com/inrupt/pod-server/tree/lerna)

michielbdejong commented 5 years ago

Can we also get this fixed in master?

michielbdejong commented 5 years ago

Also running into dist/node_modules/mashlib thing

jaxoncreed commented 5 years ago

I'll see if this is still a problem after the refactor. I'm building a special handler for rendering mashlib