search

insane-adding-machines / unicore-mx

UniCore-MX | Universal Core for ARM Cortex-M0/0+/3/4/7/X
GNU General Public License v3.0
50 stars 8 forks source link

incorrect naming #15

Open kuldeepdhaka opened 7 years ago

kuldeepdhaka commented 7 years ago

https://github.com/insane-adding-machines/unicore-mx/blob/master/include/unicore-mx/stm32/common/adc_common_v2_single.h#L52 should be ADC_CFGR1_EXTSEL_MASK

kuldeepdhaka commented 7 years ago

https://github.com/insane-adding-machines/unicore-mx/blob/cfc738cce04cb6bf815ae5377ed3dea25d9c02e4/include/unicore-mx/stm32/f0/adc.h#L82 should be ADC_SMPR_SMP_MASK

brabo commented 7 years ago

@kuldeepdhaka entirely correct, nice catch! We can fix these, but we should note this down to check the headers for items as this with the overhaul.