search

insanehunter / XCode4_beginning_of_line

Xcode plugin to make HOME key jump to the first non-whitespace line of code
168 stars 21 forks source link

add `⌘+delete` functionality #8

Closed hlung closed 10 years ago

hlung commented 10 years ago
insanehunter commented 10 years ago

Thank you for your effort. Renaming the project is good point, but what happens if someone with older version installed builds a newer one? Shouldn't we add a build step checking if previous one is here and removing it?

Also, Xcode is spelled as Xcode, not XCode. That was my fault, but if we go into renaming, why not fix it as well?

And could you please replace tabs in source file with spaces, as the rest of the code uses spaces, and mixing them makes diffs look ugly with misplaced lines.

And the last one: do we really need those *.xccheckout files in a repository? I'm not using Xcode for versioning, so I don't know if they should be committed or not (and I'm not against leaving them, I'm just curious).

Please forgive me being too pedantic :)

hlung commented 10 years ago

Oh, I just noticed too. I like naming it correctly so will definitely change it to Xcode.

Will also fix tabs and *.xccheckout. I saw suggestions NOT to include xccheckout from here.

Not sure if we should create a script to remove the previous version though. I think mentioning that we change the plugin name in the repo readme file should be enough. But, that's up to you ;)

insanehunter commented 10 years ago

Fair enough. I'll update the Readme and add checking for previous version once you've done.

hlung commented 10 years ago

Great! btw I'm heading out for dinner now, will continue tomorrow when I have time ;)

hlung commented 10 years ago

One thing I noticed in your current file. You are using both tabs and spaces. screen shot 2013-10-30 at 12 26 45 pm

I also use tabs but I assume you want to change it to all spaces. So I'm not sure if you want it all space or tabs.

insanehunter commented 10 years ago

Oh, that's nasty. Shame on me. I'll fix it myself, to not take your time anymore. Thank you for a great job!

hlung commented 10 years ago

Sorry, I made a mistake. I forgot to change the class name so it still says XCode4_beginning_of_line. Please have a look at that too. Thanks.

insanehunter commented 10 years ago

Yep, I see. Don't worry, I fixed that :)