insani-org / onscripter-insani

A branch of ONScripter by Ogapee. Focuses on portability and builds for modern Windows and macOS. Also see ONScripter-EN (https://github.com/Galladite27/ONScripter-en), which is our sister project.
http://nscripter.insani.org
GNU General Public License v2.0
37 stars 2 forks source link

MP3 playback non-functional #3

Closed lightbinder closed 1 year ago

lightbinder commented 1 year ago

MP3 playback is currently non-functional in our packaged builds.

The reason behind this is simple: neither Homebrew nor MSYS2 build SDL_mixer with MP3 support by default. That is a compile-time option. It is looking likely that we will have to compile SDL_mixer ourselves and package it with our distribution should MP3 playback be desired (which it is).

In the short term, Ogg Vorbis playback is fully functional and most of the insani catalog of novel games utilized Ogg Vorbis rather than MP3. However, I consider this a high priority enough issue for a plurality and perhaps even majority of all released NScripter games.

*sigh* ... I was hoping to avoid this ...

lightbinder commented 1 year ago

Confirmed -- simply rebuilding SDL_mixer with proper SMPEG support (--enable-music-mp3) does it. On macOS the brew formula has to be fairly heavily updated in order to compile at all. Will move to a 20230413.1 point release that simply has updated SDL_mixer for all platforms. This bug will stay open until that release is engineered and out the door.

lightbinder commented 1 year ago

Resolved in Release 20230413-1 "BaseSon"