search

insanum / gcalcli

Google Calendar Command Line Interface
MIT License
3.27k stars 307 forks source link

Update documented syntax for manual login options #547

Open tylerdq opened 4 years ago

tylerdq commented 4 years ago

Changed hyphens to underscores in authentication option names. As mentioned in issue #523, the options need underscores (not hyphens) yet the documentation still instructed to use hyphens.

jcrowgey commented 3 years ago

There was an effort recently to switch gcalcli over to all posix-style flag conventions, so no more camel case or underscores. To my reading, we've got a bug in the plumbing through from PROGRAM_OPTIONS to the call to the Oauth workflow on lines 141/142 of gcal.py. But we should fix that bug, not just change the documentation to suggest using options that we've purposefully deprecated. Even if we change course and decide to undeprecate the underscored versions of these options, we'd need a PR that actually deals with deprecations.py.

Should I close this PR or leave it open for you to work on the potential option-plumbing bug?