insanum / gcalcli

Google Calendar Command Line Interface
MIT License
3.27k stars 307 forks source link

flake8 and mypy warnings #576

Open michaelmhoffman opened 3 years ago

michaelmhoffman commented 3 years ago

Having all the existing flake8 and mypy warnings makes it harder to notice when new errors are added by changes to code. Given #83 and #164, can I assume pure refactoring and style pull requests would be welcome?

Example of warnings reported by Emacs flycheck from gcalcli/gcal.py:

 gcal.py     1   1 info     D100   Missing docstring in public module (python-flake8)
 gcal.py     5   1 error           Skipping analyzing 'httplib2': found module but no type hints or library stubs (python-mypy)
 gcal.py     5   1 info            See https://mypy.readthedocs.io/en/latest/running_mypy.html#missing-imports (python-mypy)
 gcal.py    14   1 error           Cannot find implementation or library stub for module named 'cPickle' (python-mypy)
 gcal.py    14   6 info     N813   camelcase 'cPickle' imported as lowercase 'pickle' (python-flake8)
 gcal.py    16   5 error           Name 'pickle' already defined (possibly by an import) (python-mypy)
 gcal.py    35   1 error           Skipping analyzing 'apiclient.discovery': found module but no type hints or library stubs (python-mypy)
 gcal.py    36   1 error           Skipping analyzing 'apiclient.errors': found module but no type hints or library stubs (python-mypy)
 gcal.py    37   1 error           Skipping analyzing 'oauth2client.file': found module but no type hints or library stubs (python-mypy)
 gcal.py    38   1 error           Skipping analyzing 'oauth2client.client': found module but no type hints or library stubs (python-mypy)
 gcal.py    39   1 error           Skipping analyzing 'oauth2client': found module but no type hints or library stubs (python-mypy)
 gcal.py    46   1 warning  E302   expected 2 blank lines, found 1 (python-flake8)
 gcal.py    46   1 info     D101   Missing docstring in public class (python-flake8)
 gcal.py    48   5 error           Need type annotation for 'cache' (hint: "cache: Dict[<type>, <type>] = ...") (python-mypy)
 gcal.py    49   5 error           Need type annotation for 'all_cals' (hint: "all_cals: List[<type>] = ...") (python-mypy)
 gcal.py    64   1 info     D107   Missing docstring in __init__ (python-flake8)
 gcal.py   159   1 info     D102   Missing docstring in public method (python-flake8)
 gcal.py   167   5 warning  C901   'GoogleCalendarInterface._get_cached' is too complex (12) (python-flake8)
 gcal.py   256   1 info     D205   1 blank line required between summary line and description (python-flake8)
 gcal.py   256   1 info     D400   First line should end with a period (python-flake8)
 gcal.py   291   5 warning  C901   'GoogleCalendarInterface._get_week_events' is too complex (14) (python-flake8)
 gcal.py   436   5 warning  C901   'GoogleCalendarInterface._GraphEvents' is too complex (18) (python-flake8)
 gcal.py   436  10 info     N802   function name '_GraphEvents' should be lowercase (python-flake8)
 gcal.py   609   5 warning  C901   'GoogleCalendarInterface._PrintEvent' is too complex (31) (python-flake8)
 gcal.py   609  10 info     N802   function name '_PrintEvent' should be lowercase (python-flake8)
 gcal.py   859  10 info     N802   function name '_SetEventStartEnd' should be lowercase (python-flake8)
 gcal.py   879   5 warning  C901   'GoogleCalendarInterface._edit_event' is too complex (28) (python-flake8)
 gcal.py  1031  10 info     N802   function name '_GetAllEvents' should be lowercase (python-flake8)
 gcal.py  1078  14 info     N806   variable 'pageToken' in function should be lowercase (python-flake8)
 gcal.py  1114  10 info     N802   function name '_DeclinedEvent' should be lowercase (python-flake8)
 gcal.py  1122   1 info     D102   Missing docstring in public method (python-flake8)
 gcal.py  1122  10 info     N802   function name 'ListAllCalendars' should be lowercase (python-flake8)
 gcal.py  1157   1 info     D102   Missing docstring in public method (python-flake8)
 gcal.py  1157  10 info     N802   function name 'TextQuery' should be lowercase (python-flake8)
 gcal.py  1164   1 info     D102   Missing docstring in public method (python-flake8)
 gcal.py  1164  10 info     N802   function name 'UpdatesQuery' should be lowercase (python-flake8)
 gcal.py  1183   1 info     D102   Missing docstring in public method (python-flake8)
 gcal.py  1183  10 info     N802   function name 'ConflictsQuery' should be lowercase (python-flake8)
 gcal.py  1199   1 info     D102   Missing docstring in public method (python-flake8)
 gcal.py  1199  10 info     N802   function name 'AgendaQuery' should be lowercase (python-flake8)
 gcal.py  1208   1 info     D102   Missing docstring in public method (python-flake8)
 gcal.py  1208  10 info     N802   function name 'AgendaUpdate' should be lowercase (python-flake8)
 gcal.py  1257   1 info     D102   Missing docstring in public method (python-flake8)
 gcal.py  1257  10 info     N802   function name 'CalQuery' should be lowercase (python-flake8)
 gcal.py  1301  10 info     N802   function name 'QuickAddEvent' should be lowercase (python-flake8)
 gcal.py  1302   1 info     D400   First line should end with a period (python-flake8)
 gcal.py  1302   1 info     D401   First line should be in imperative mood; try rephrasing (python-flake8)
 gcal.py  1345   1 info     D102   Missing docstring in public method (python-flake8)
 gcal.py  1345  10 info     N802   function name 'AddEvent' should be lowercase (python-flake8)
 gcal.py  1400   1 info     D102   Missing docstring in public method (python-flake8)
 gcal.py  1400  10 info     N802   function name 'ModifyEvents' should be lowercase (python-flake8)
 gcal.py  1410  10 info     N802   function name 'Remind' should be lowercase (python-flake8)
 gcal.py  1411   1 info     D202   No blank lines allowed after function docstring (python-flake8)
 gcal.py  1463   1 info     D102   Missing docstring in public method (python-flake8)
 gcal.py  1463   5 warning  C901   'GoogleCalendarInterface.ImportICS' is too complex (46) (python-flake8)
 gcal.py  1463  10 info     N802   function name 'ImportICS' should be lowercase (python-flake8)
 gcal.py  1464  20 info     N803   argument name 'icsFile' should be lowercase (python-flake8)
 gcal.py  1466  14 info     N802   function name 'CreateEventFromVOBJ' should be lowercase (python-flake8)
 gcal.py  1583   1 error           Skipping analyzing 'vobject': found module but no type hints or library stubs (python-mypy)