search

insanum / obsidian_gruvbox

A gruvbox theme for Obsidian
MIT License
162 stars 38 forks source link

Add callout colors #29

Closed xaqbr closed 8 months ago

xaqbr commented 2 years ago

Previous dark: ![image](https://user-images.githubusercontent.com/3822492/192142322-01c42be8-9b01-452e-a5f1-88bbfc535735.png | width=100)

New dark: image

Previous light: image

New light: image

Fixes #26

insanum commented 2 years ago

This looks good. I like the way the callouts pop.

Can you please change all your color arrays to use variables inside theme-dark or theme-light? Then you can cut the amount of CSS in half as you've duplicated most selectors for both dark/light. You'll only need to specify a single selector with the corresponding variable color which will work for both dark/light.

insanum commented 2 years ago

If you'd like to see this committed please simplify the code as previously requested and update for the new Obsidian v1.x theming style (i.e. rebase your changes).

insanum commented 8 months ago

Different pull request that picked up the ideas for callouts here was merged.