insanum / sncli

Simplenote CLI
MIT License
397 stars 35 forks source link

Fix issue #129 pep-8 sorted imports #130

Open clach04 opened 2 years ago

clach04 commented 2 years ago

Used isort to automate. Now have per line imports following pep8 order. Remove duplicate datetime import.

clach04 commented 2 years ago

Hmmm, easy answer is; your project, your rules ;-)

You might want to consider looking at:

I don't have that many large projects so I've not invested much time into automation, ideas to check out:

Right now my advice would be don't rush into anything.

samuelallan72 commented 2 years ago

Yep that's fair, thanks. :+1:

Perhaps for now, a Makefile target that runs the isort command you used to generate these changes - then at least we have a record and can keep it consistent.

lostways commented 1 year ago

If this is still being considered..... I agree with using a workflow/pre-commit hook to automate formatting if you want to keep it standard. black is industry standard in terms of formatting but would probably change a lot in the codebase.

However, for now, instead of a Makefile you might want to add isort as a dependency and some docs on how to run it before you add any more automated or abstracted way to do it.

It would be best to keep this PR separate from any PR that implements automation. There isn't a lot of development going on so automation isn't an immediate need. Implementing it can be complex and would probably deserve it's own PR.