added alternate host config option and support for custom config file

insanum / sncli

Simplenote CLI

MIT License

396 stars 34 forks source link

added alternate host config option and support for custom config file #22

Closed samuelallan72 closed 8 years ago

samuelallan72 commented 8 years ago

Added a config option (cfg_sn_host) to enable connecting to alternate servers running a simplenote compatible api.
Added a command line arg option to enable using multiple accounts/configurations with the same computer or user account.

samuelallan72 commented 8 years ago

Any updates on plans to merge this or not?

insanum commented 8 years ago

Hey @swalladge this is a nice change. Sorry for no following up earlier. I'm not using Simplenote like I used to so this project of mine has kind of fallen off my radar. I'll let @axs221 follow up with the merge. :-)

Curious... what are the "servers" running a Simplenote compatible API? Is there a new open source project supporting this so you can host yourself or something?

samuelallan72 commented 8 years ago

@insanum I'm currently developing one at swalladge/snsrv - been using sncli with these modifications to help test it. As far as I know, no other serious projects offer a simplenote compatible api (there are some incomplete ones aimed at testing, like wezm/simplistic-notes).

samuelallan72 commented 8 years ago

The above commits basically do the following:

update codebase to work fully with python3
attempt to standardize string handling to avoid encoding errors
use the excellent Requests python library for network requests (much cleaner)
refactor some minor things to reflect changes from python2 to python3 (ie. note sorting, md5 functions)

I've been testing it for a while now without any apparent problems, and working with utf-8 characters outside the ascii range doesn't crash it any more.

samuelallan72 commented 8 years ago

@insanum do you have anything against updating the code from python 2 to 3, or taking on another dependency (Requests), since these are 'breaking changes'? Also, what's your policy with merging changes? Would you like new 'unstable' branches, or just pull everything into master and maybe tag milestones?

insanum commented 8 years ago

@swalladge I don't think there are enough users of sncli to warrant a strict release/roadmap process, branch management, etc. Go with what you feel is best. If you think having an unstable branch is necessary then cool. If not then cool. :-)

samuelallan72 commented 8 years ago

Ok cool, let's go! :)