fix the UTM_ZONE confusion - Githubissues

insarlab / MintPy

Miami InSAR time-series software in Python

https://mintpy.readthedocs.io

Other

575 stars 252 forks source link

fix the UTM_ZONE confusion #1053

Closed yunjunz closed 1 year ago

yunjunz commented 1 year ago

Description of proposed changes

This PR fixes the previous confusion that UTM_ZONE should end with the hemisphere, not the latitude band, which is not part of UTM but part of MGRS, as described in https://github.com/insarlab/MintPy/pull/1052#discussion_r1280899939.

utils.utils0.utm_zone2epsg_code(): revert back the south arg feeding from UTM_ZONE
utils.utils0.utm2latlon(): use the northern arg instead of the latitude band, to match the meaning of UTM_ZONE metadata
utils.utils0.latlon2utm(): return east/north only, for simplicity and style consistency with utm2latlon.
docs/api/attributes.UTM_ZONE: add more description and examples

Reminders

[x] Pass Pre-commit check (green)
[x] Pass Codacy code review (green)
[x] Pass Circle CI test (green)
[x] Make sure that your code follows our style. Use the other functions/files as a basis.
[x] If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.