Closed forrestfwilliams closed 6 months ago
Also related to discussion #1010
Hey @yunjunz, I would appreciate your thoughts on this whenever you have time.
Thanks for the review @yunjunz! I've made the suggested changes, modified yx2lalo
to match the structure of lalo2yx
, and updated its uses. This is ready for you to look at again!
Not sure why the pre-commit check is failing.
Not sure why the pre-commit check is failing.
Have you set up the pre-commit for your MintPy local repo, following the instructions here? All the checks and/or modifications will be done automatically when you do the git commit.
Awesome, thanks @yunjunz! Do you think we could create a new release of MintPy soon with these changes? I ended up pursuing this work to support some tutorials ASF's OpenSARLab team runs and it would be great to get them a new release with these changes.
Sure thing, let's cut for a new release for it. There are a few recently open PRs from the JPL folks, it will be nice to merge those before the new release, likely this week.
Hi @forrestfwilliams, I think the code is ready for a new release. As for the proposed changes in https://github.com/insarlab/MintPy/issues/1162, doing them either before or after the release is fine with me, let me know please.
Hey @yunjunz sorry for the slow response. I'll open a PR for the changes discussed in #1162 next week, then we can release!
Description of proposed changes
HyP3 (and I believe NISAR as well) both output their InSAR products in UTM coordinates. While MintPy was originally designed to use lat/lon coordinates, has limited support for UTM datasets as well. Users have noted (i.e., issue #1145) that it would be nice to better support UTM datasets.
This PR adds some additional support for UTM datasets, in plotting and GPS comparison contexts by:
coords.coordinate.latlon2yx
works with UTM coordinatescoords.coordinate.geo2rdr
works with UTM coordinatesTo accomplish this, checks for the use of UTM coordinates were added to
latlon2yx
andgeo2rdr
. Also, the inputs forlatlon2yx
was changed from a coordinate and a coordinate type (lat or lon) to a pair of lat/lon or northing/easting coordinates. All uses oflatlon2yx
were changed to use this new input format.Reminders