Add HDF-EOS5 metadata for HyP3 products

insarlab / MintPy

Miami InSAR time-series software in Python

https://mintpy.readthedocs.io

Other

555 stars 244 forks source link

Add HDF-EOS5 metadata for HyP3 products #1180

Closed forrestfwilliams closed 2 months ago

forrestfwilliams commented 2 months ago

Description of proposed changes At @yunjunz's suggestion, this PR adds the startUTC, stopUTC, and relativeOrbit fields to HyP3-derived products to support HDF-EOS5 conversion.

Reminders

[x] Fix #1162
[x] Pass Pre-commit check (green)
[x] Pass Codacy code review (green)
[x] Pass Circle CI test (green)
[x] Make sure that your code follows our style. Use the other functions/files as a basis.
[x] If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.
[x] If adding new functionality, add a detailed description to the documentation and/or an example.

forrestfwilliams commented 2 months ago

@yunjunz not sure I got startUTC and stopUTC right here. Should these be attributes of each interferogram, or are they the start/stop time for the entire stack (i.e., min input SLC date, and max input SLC date)?

yunjunz commented 2 months ago

Hi @forrestfwilliams, start/stopUTC should come from the same acquisition, so the current calculation should be fine.

My misunderstanding: the start/stopUTC should come from the same acquisition, i.e. the starting and ending time of one image, so the current calculation is NOT correct. We could grab the two time stamps from the Reference or Secondary file name directly.

forrestfwilliams commented 2 months ago

Sounds good! Do we need to update startUTC/stopUTC, or are they correct now?

yunjunz commented 2 months ago

Sounds good! Do we need to update startUTC/stopUTC, or are they correct now?

They are fixed now.