insarlab / PySolid

A Python wrapper for solid Earth tides
GNU General Public License v3.0
63 stars 9 forks source link

packaging: `setuptools_scm` + `pyproject.toml` + `cibuildwheels` #43

Closed jhkennedy closed 1 year ago

jhkennedy commented 1 year ago

This

jhkennedy commented 1 year ago

clibuildwheel is working for Linux and Mac but not windows. I tried to get it going but am not sure where to go from here and am out of time for a little while. @yunjunz feel free to try and fix it, or we could drop windows from PyPI for now (since it's available via conda) and circle back later.

yunjunz commented 1 year ago

Thank you @jhkennedy for the many nice changes here!

cibuildwheel is working for Linux and Mac but not windows. I tried to get it going but am not sure where to go from here and am out of time for a little while. @yunjunz feel free to try and fix it, or we could drop windows from PyPI for now (since it's available via conda) and circle back later.

I gave this a quick shot, but could not figure out the solution. Dropping "Windows" from PyPI sounds like a good compromise to me.

jhkennedy commented 1 year ago

No problem @yunjunz ! I don't know if you want to open an issue for Windows wheels or just update #42 to reflect that's still open (it's linked and will be closed by this PR currently)

yunjunz commented 1 year ago

No problem @yunjunz ! I don't know if you want to open an issue for Windows wheels or just update #42 to reflect that's still open (it's linked and will be closed by this PR currently)

Let's update #42. I have updated the description in this PR to keep it open.