search

insarlab / PySolid

A Python wrapper for solid Earth tides
GNU General Public License v3.0
61 stars 7 forks source link

`pyproject.toml`: add dynamic requirements from file #71

Closed scottstanie closed 10 months ago

scottstanie commented 10 months ago

Testing out the dynamic requirements, we'll see if the build works alright with the "setuptools<60.0" pin.

scottstanie commented 10 months ago

Thank you @scottstanie. While testing the installation as below, the extra docs,test is not recognized. Am I using the correct syntax?

No that does look correct, I'm checking again and I think I missed that warning the first time I tested it.

It's set up exactly the same as dolphin, so my only guess is that having a setup.py is overriding these sections of the pyproject... I'll check if I can find a workaround, but otherwise we might need to have it in the setup.py and not the pyproject.toml

scottstanie commented 10 months ago

Oh no nevermind, it was related to my concern about "setuptools<60.0". When I flip that to "setuptools>=64.0", it recognizes .[docs] or .[docs,test].... but then the wheel build fails 🙀

scottstanie commented 10 months ago

That sounds good to me

yunjunz commented 10 months ago

I think we could safely merge this PR as all previous tests passed without issue (no need to wait for another 1 hour), we have only comments change after that.

If you think it's ready, could you cut a new release (version 0.3.1) after the PR?

Would you like to be added as a maintainer on the conda-forge repo? I forgot to ask you in the last PR.