insarlab / PySolid

A Python wrapper for solid Earth tides
GNU General Public License v3.0
61 stars 7 forks source link

move packaging and installation requirements to tests/requirements.txt #77

Closed jhkennedy closed 7 months ago

jhkennedy commented 7 months ago

@yunjunz this will fix #76, and shouldn't require any docs or CI/CD changes.

Basically, this:

which is fine overall (if you're developing, you should be testing!) and coherent with the docs.

Strictly speaking, I don't think you need to list setuptools, setuptools_scm, or wheel as development dependencies as pip will do isolated builds if a pyproject.toml is present and pull the build dependencies from the [build-system] requirements listed there.

But, I do like having setuptools_scm in the dev environment so I can easily check what version it thinks the project is on with:

python -m setuptools_scm

If you're going to keep them, however, it's probably worth including the same pins in the requirements.txt files as pyproject.toml:

requires = ["setuptools<60.0", "setuptools_scm[toml]>=6.2", "numpy<1.23.0", "wheel"]