search

inseven / builds

GitHub Actions status board for macOS and iOS
MIT License
1 stars 1 forks source link

Use `WorkflowInstance.ID` for the widget configuration intents #332

Closed jbmorley closed 4 months ago

jbmorley commented 4 months ago

Right now the widget introduces a new WorkflowIdentifier to be used in the configuration intent. This is essentially a duplicate of WorkflowInstance.ID and ideally we would have just the one.

I did this because I was finding that the intent wasn't working correctly when defined in BuildsCore. Perhaps there's a middle ground where the intent conformance can be added in the widget, with the struct definition living in BuildsCore.

jbmorley commented 4 months ago

Unfortunately it looks like this really isn't possible (thanks Xcode), so WorkflowIdentifier can just become a wrapper struct.