search

inseven / opolua

A compiled-OPL interpreter for iOS written in Lua
https://opolua.org
MIT License
12 stars 0 forks source link

Adding locations from different points in the same directory hierarchy probably cause a crash #120

Closed jbmorley closed 2 years ago

jbmorley commented 2 years ago

Right now the code will let you add a folder and one of its descendants as library locations. That will cause the detector to potentially discover the same files in both structures, which won't have unique URLs, meaning they'll probably cause the All Programs view diffable data source to crash.

The solution is probably to de-duplicate in the program detector. Alternatively, we could store the parent location alongside items and unique on both that and the URL. Either way, it might be useful to store the parent as it would make it easier to implement a 'Reveal in Library' later on.

jbmorley commented 2 years ago

Crashes are bad. v1.

jbmorley commented 2 years ago

Fixed as part of the change for #39 (7bee7b555f1ebed2f6e7c6ef7c7076b965b57a2c). The current solution simply deduplicates the detected programs by URL.