Don't over-notify `RecursiveDirectoryMonitor` observers

inseven / opolua

A compiled-OPL interpreter for iOS written in Lua

https://opolua.org

MIT License

12 stars 0 forks source link

Don't over-notify `RecursiveDirectoryMonitor` observers #145

Closed jbmorley closed 2 years ago

jbmorley commented 2 years ago

Right now RecursiveDirectoryMonitor observers will get notified of every change affecting any of the observed locations (across all observers). This means that those observers will necessarily end up doing more work than they need to.

We should be able to associate discovered URLs with the observer context that yielded them and then use this to determine which observers to dispatch notifications to.

jbmorley commented 2 years ago

Definitely not 1.0.0.

jbmorley commented 2 years ago

Closing as won't fix. We can reraise this issue if we actually see performance issues as a result of this.