search

inside / vim-search-pulse

Easily locate the cursor after a search
127 stars 8 forks source link

`search_pulse#PulseFirst` not supported in Neovim #28

Closed shyun3 closed 3 months ago

shyun3 commented 3 months ago

I noticed that search_pulse#PulseFirst specifically checks for Neovim here. The comment says that state() doesn't exist on Neovim. This function looks to be supported in the latest version of Neovim (v0.10), see [docs](https://neovim.io/doc/user/builtin.html#state()). Is this check still necessary?

inside commented 3 months ago

Thank you for pointing this out and this check is not necessary anymore. Do you want to create a PR for this?

On Wed, 5 Jun 2024 at 18:44, shyun3 @.***> wrote:

I noticed that search_pulse#PulseFirst specifically checks for Neovim here https://github.com/inside/vim-search-pulse/blob/3ae2681332c52ed54c443e09d2ef09ae05eaa445/autoload/search_pulse.vim#L63-L64. The comment says that state() doesn't exist on Neovim. This function looks to be supported in the latest version of Neovim (v0.10), see docs https://neovim.io/doc/user/builtin.html#state(). Is this check still necessary?

— Reply to this email directly, view it on GitHub https://github.com/inside/vim-search-pulse/issues/28, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA2K3DXNTCO7HT3MKVPDW3ZF46ANAVCNFSM6AAAAABI3DCIVWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGMZTMMZXHAYDAOA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

shyun3 commented 3 months ago

Sure, I could take a crack at it.