insideapp-oss / sonar-apple

SonarQube plugin for Swift / Objective-C

Other

97 stars 2 forks source link

Refact MobSFScan components #51

Closed gaelfoppolo closed 1 year ago

gaelfoppolo commented 1 year ago

Summary

This PR aims to refactor MobSFScan components with many goals:

use the dependency injection system of SonarQube
improve the modularity and testability
improve performances

Some details

Removed RunningSourcesCLISensor in favor of CommandLineToolRunner
Only one MobSF sensor now instead of one for Swift and Objective-C
Moved the sensor to Apple Plugin folder
Now only one command is run instead of one for each source folder
Used the dependency injection system of SonarQube extensively

DoD

[x] Implementation
[x] Unit tests
[x] Same MobSF issues on several project as before
[x] Cleaning of the old implementation & tests