search

insidesherpa / JPMC-tech-task-1

56 stars 352 forks source link

Ratio still coming up as 1 #250

Open mcgrawj012 opened 3 years ago

mcgrawj012 commented 3 years ago

After making the changes to the file I am still getting the same answers from the original. Screen Shot 2021-03-17 at 5 10 41 PM

Bilal-K20 commented 3 years ago

I have had this same issue and i am sure feel strong that my code is correct but u still some how get the same thing

Al1374525 commented 3 years ago

ive been getting the same error as well; im pretty confident that i got it right, but it keeps getting the same thing

Gily-H commented 3 years ago

On line 39 it might have to do with the way you are calling the getRatio() method. The getRatio() method takes two parameters, but it seems like you are passing in three parameters in your example.