search

insight-lane / crash-model

Build a crash prediction modeling application that leverages multiple data sources to generate a set of dynamic predictions we can use to identify potential trouble spots and direct timely safety interventions.
https://insightlane.org
MIT License
113 stars 40 forks source link

Data standards #149

Closed terryf82 closed 5 years ago

terryf82 commented 5 years ago

set default city lat/lng in new config from geocoded response

j-t-t commented 5 years ago

Let's get Shreya's initialize_city test changes into master before we merge this so we can decide whether you should flesh out the test you wrote or just update her test

j-t-t commented 5 years ago

The test_brisbane_config file is getting written to src/. Can you create a temp directory and write there instead?

terryf82 commented 5 years ago

@j-t-t thanks, path updated and CI tests running now.

j-t-t commented 5 years ago

Sorry, I should have been more specific. Best to use a tmpdir created for this test. Test functions can take an argument called tmpdir and you can use that. https://docs.pytest.org/en/latest/tmpdir.html

terryf82 commented 5 years ago

@j-t-t thanks, updated with proper use of tmpdir fixture.